Bug #9343

[Keep] MakeArvadosClient is asking for extra unneded environment variables

Added by Nico César about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
06/02/2016
Due date:
% Done:

0%

Estimated time:
Story points:
0.5

Description

b002129afda08bbb4fdbed6e629858a5c298c068 added

+// NewClientFromEnv creates a new Client that uses the default HTTP
+// client with the API endpoint and credentials given by the
+// ARVADOS_API_* environment variables.
+func NewClientFromEnv() *Client {
+       return &Client{
+               APIHost:   os.Getenv("ARVADOS_API_HOST"),
+               AuthToken: os.Getenv("ARVADOS_API_TOKEN"),
+               Insecure:  os.Getenv("ARVADOS_API_HOST_INSECURE") != "",
+       }
+}
+

that causes the keepstore server to ask for those variables or fail:

2016-06-02_20:22:10.20202 Starting keepstore0 from /etc/sv/keepstore0
2016-06-02_20:22:10.28620 2016/06/02 20:22:10 keepstore starting, pid 10049
2016-06-02_20:22:10.28623 2016/06/02 20:22:10 Using volume s3-bucket:"4xphq-keep" (writable=true)
2016-06-02_20:22:10.28625 2016/06/02 20:22:10 -max-requests <1 or not specified; defaulting to maxBuffers * 2 == 256
2016-06-02_20:22:10.30418 2016/06/02 20:22:10 MakeArvadosClient: Missing required environment variable ARVADOS_API_HOST
2016-06-02_20:22:10.31998 Stopping keepstore0

Associated revisions

Revision e6cb6691
Added by Tom Clegg about 3 years ago

Merge branch '9343-no-env-vars'

refs #9343

History

#1 Updated by Tom Clegg about 3 years ago

  • Category set to Keep
  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg
  • Target version set to 2016-06-08 sprint
  • Story points set to 0.5

#2 Updated by Tom Clegg about 3 years ago

  • Subject changed from [Keep] MakeArvadosClient is asking for extra unneded environment variables to [Keep] MakeArvadosClient is asking for extra unneded environment variables
  • Status changed from In Progress to Feedback

#3 Updated by Tom Clegg about 3 years ago

  • Assigned To changed from Tom Clegg to Nico César

#4 Updated by Tom Clegg about 3 years ago

  • Status changed from Feedback to Resolved
  • Assigned To changed from Nico César to Tom Clegg

Also available in: Atom PDF