Arvados

Branch 9426-collection-tags @ 8eef061d1e3c8fcc03b89637e18c91e04689614f

Implements "editable table" layout for the collection tags.

• File apps/workbench/app/controllers/collections_controller.rb
  • Lines 366-369: Do you think this would be more readable by negating the conditional so there’s no empty block on the “true” case? For example:
    

    if not @object.update_attributes….
        self.render_error…
    end
    

• Adding a duplicated key silently overwrites the first one, should this be checked to avoid changing previous values without notice?
• When having lots of tags, the bottom of the tag table will pass the browser boundaries. When the user clicks on “Edit”, it will have to manually scroll to the bottom to be able to see/access the rest of the action buttons (Add/Save/Cancel). Do you think it would be a good idea to scroll the page to the bottom when clicking “Edit”? Here’s an example https://github.com/GabrielDelepine/smooth-scroll
  (The alternative would be to duplicate the buttons, but as the new tags are added to the bottom of the table, it makes no sense to have them on the top.)
• Newlines on key and value are removed, is that correct behavior? If so, could we restrict the editable text box so that no newlines are accepted?

@ c2a1539e64937b126c0090bc5d9fe8d65411be8f

File apps/workbench/app/controllers/collections_controller.rb -- Lines 366-369

Updated this to address a race condition with refresh and now there are no inconsistencies when saving tags (as seen towards the end of demo on Tuesday)

Adding a duplicated key silently overwrites the first one, should this be checked to avoid changing previous values without notice?

I expect the user to know (or to eventually know) that this is a hash table and keys won't be duplicated. I really do not think we can do much about this. Leaving this as is.

When having lots of tags, the bottom of the tag table will pass the browser boundaries. When the user clicks on “Edit”, it will have to manually scroll to the bottom to be able to see/access the rest of the action buttons (Add/Save/Cancel). Do you think it would be a good idea to scroll the page to the bottom when clicking “Edit”? Here’s an example

What if the user wants to edit the "first" / tags at the top of the table? I really don't think this would be a problem. The scroll bar is there to let the user know that there is "more" in the page, and to be frank the user couldn't have ended up with those many tags before entering the first tag etc. Leaving this as is until further feedback from someone like Bryan or other customers.

Newlines on key and value are removed, is that correct behavior? If so, could we restrict the editable text box so that no newlines are accepted?

This is a great idea. I updated the javascript and css to suppress new lines. Javascript to prevent typing newline characters and CSS to prevent pasting new lines from copied text.

Thanks.

This LGTM, please merge.

Branch 9426-collection-tags-as-properties @ ef4ca87900bd023849aca62952ad2a27cfe40d34

Save tags as properties rather than as a field in properties.

Test run @ https://ci.curoverse.com/job/developer-run-tests/354/

Reviewing updates at ef4ca8790.

LGTM, please merge.