Bug #9491

[keepproxy] Does not respect X-Keep-Desired-Replicas

Added by Brett Smith over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
06/24/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

9tee4 is currently running keepproxy 0.1.20160606192603.55febaa-1. It has one proxy and two disk services.

% echo 'hello, alice' >alice.txt
% curl -H 'X-Keep-Desired-Replicas: 1' -H 'Authorization: …' -T alice.txt -D response.headers.log https://keep.9tee4.arvadosapi.com/03032680d3fa0561ef4f85071140861e
03032680d3fa0561ef4f85071140861e+13+A…
% cat response.headers.log
HTTP/1.1 100 Continue

HTTP/1.1 200 OK
Server: nginx/1.8.1
Date: Fri, 24 Jun 2016 15:16:20 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 86
Connection: keep-alive
Access-Control-Allow-Headers: Authorization, Content-Length, Content-Type, X-Keep-Desired-Replicas
Access-Control-Allow-Methods: GET, HEAD, POST, PUT, OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Max-Age: 86486400
X-Keep-Replicas-Stored: 2

I expect X-Keep-Replicas-Stored in the response to be 1.


Subtasks

Task #9493: Review 9491-desired-replicasResolvedTom Clegg

Associated revisions

Revision 6c058848
Added by Tom Clegg over 4 years ago

Merge branch '9491-desired-replicas'

closes #9491

History

#1 Updated by Brett Smith over 4 years ago

(11:26:54 AM) brett: https://github.com/curoverse/arvados/blob/master/services/keepproxy/keepproxy.go#L427 - Shouldn't this be `err == nil`?
(11:27:10 AM) tom: brett: I think you nailed it

#2 Updated by Tom Clegg over 4 years ago

  • Category set to Keep
  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg
  • Target version set to 2016-07-06 sprint
  • Story points set to 0.5

#3 Updated by Tom Clegg over 4 years ago

9491-desired-replicas @ 6e97eab

#4 Updated by Lucas Di Pentima over 4 years ago

Looks good to me.

#5 Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:6c0588485bc29736929ebb6997c8fe6879dbf9eb.

Also available in: Atom PDF