Bug #9513

[Keep] keepproxy should not set content-length to -1 when responding 411 Length Required

Added by Tom Clegg over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
06/29/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

The code that checks the Content-Length request header for PUT requests, inexplicably, copies the request header into the response headers if there was an error parsing it as an int. It's unclear whether the intent was truly to copy the header when parsing failed, or whether err!=nil was a typo and the intent was to copy the header when parsing succeeded, but neither makes any sense: invalid headers are invalid, and there's no reason to expect the PUT response body to be the same size as the request body.


Subtasks

Task #9517: Review 9513-keepproxy-content-lengthResolvedTom Clegg

Associated revisions

Revision 5f164d87
Added by Tom Clegg over 4 years ago

Merge branch '9513-keepproxy-content-length'

closes #9513

History

#1 Updated by Tom Clegg over 4 years ago

  • Target version set to 2016-07-06 sprint

#2 Updated by Tom Clegg over 4 years ago

  • Category set to Keep
  • Assigned To set to Tom Clegg

9513-keepproxy-content-length @ 76d6d56

#3 Updated by Tom Clegg over 4 years ago

  • Description updated (diff)

#4 Updated by Lucas Di Pentima over 4 years ago

Looks good to me!

#5 Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:5f164d87da5241099d545b15ad537be69243a200.

Also available in: Atom PDF