Story #9804

[Workbench] Drop activity pane from collections view

Added by Tom Morris over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/17/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #9808: Review 9804-drop-activity-paneResolvedRadhika Chippada

Associated revisions

Revision d1855792
Added by Lucas Di Pentima over 4 years ago

Merge branch '9804-drop-activity-pane'

9804: Deleted activity pane from Workbench's collection view, a couple of queries that became unused on collection controller and updated the related tests. Closes #9804.

History

#1 Updated by Tom Morris over 4 years ago

  • Project changed from OPS to Arvados
  • Assigned To set to Lucas Di Pentima

#2 Updated by Lucas Di Pentima over 4 years ago

3f23d6f
Removed the pane, a related query to the database on the controller, and the test checking it.

#3 Updated by Lucas Di Pentima over 4 years ago

  • Status changed from New to In Progress

#4 Updated by Radhika Chippada over 4 years ago

  • Subject changed from Drop activity pane from collections view to [Workbench] Drop activity pane from collections view

#5 Updated by Radhika Chippada over 4 years ago

A few comments, mostly nitpicks

  • In show.html.erb: Regarding the pane divisions: The collection#show page seems a bit dull with two equal width big boxes on top. It seems to look prettier if I used 7 and 5 for the “details” and “sharing” panels respectively. Please update if you agree. If you like it the way it is, no big deal.
--- a/apps/workbench/app/views/collections/show.html.erb
+++ b/apps/workbench/app/views/collections/show.html.erb
@@ -1,5 +1,5 @@
 <div class="row row-fill-height">
-  <div class="col-md-6">
+  <div class="col-md-7">
     <div class="panel panel-info">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -28,7 +28,7 @@
     </div>
   </div>
   <% if current_user %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -68,7 +68,7 @@
     </div>
   </div>
   <% else %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">
  • Three tests in test/integration_performance/collections_perf_test.rb are failing for me. It may be because of my home network, but can you please double check. If they pass for you, all is good.
  • In collections_controller.rb -> @is_persistent does not seem to be used anywhere anymore. Can you please remove this if no test failures? Thanks.

#6 Updated by Lucas Di Pentima over 4 years ago

Radhika Chippada wrote:

  • In show.html.erb: Regarding the pane divisions: The collection#show page seems a bit dull with two equal width big boxes on top. It seems to look prettier if I used 7 and 5 for the “details” and “sharing” panels respectively. Please update if you agree. If you like it the way it is, no big deal.

Updated! It makes more sense the way you said.

[...]

  • Three tests in test/integration_performance/collections_perf_test.rb are failing for me. It may be because of my home network, but can you please double check. If they pass for you, all is good.

They didn't pass, I've fixed them now.

  • In collections_controller.rb -> @is_persistent does not seem to be used anywhere anymore. Can you please remove this if no test failures? Thanks.

Removed and tested, all OK!

Commited at f6a485f

Thanks!

#7 Updated by Radhika Chippada over 4 years ago

LGTM. Thanks.

#8 Updated by Lucas Di Pentima over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:d18557927ac033c2e33c1f7770881367b252f329.

Also available in: Atom PDF