Arvados

3f23d6f
Removed the pane, a related query to the database on the controller, and the test checking it.

A few comments, mostly nitpicks

• In show.html.erb: Regarding the pane divisions: The collection#show page seems a bit dull with two equal width big boxes on top. It seems to look prettier if I used 7 and 5 for the “details” and “sharing” panels respectively. Please update if you agree. If you like it the way it is, no big deal.

--- a/apps/workbench/app/views/collections/show.html.erb
+++ b/apps/workbench/app/views/collections/show.html.erb
@@ -1,5 +1,5 @@
 <div class="row row-fill-height">
-  <div class="col-md-6">
+  <div class="col-md-7">
     <div class="panel panel-info">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -28,7 +28,7 @@
     </div>
   </div>
   <% if current_user %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -68,7 +68,7 @@
     </div>
   </div>
   <% else %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">

• Three tests in test/integration_performance/collections_perf_test.rb are failing for me. It may be because of my home network, but can you please double check. If they pass for you, all is good.

• In collections_controller.rb -> @is_persistent does not seem to be used anywhere anymore. Can you please remove this if no test failures? Thanks.

Radhika Chippada wrote:

• In show.html.erb: Regarding the pane divisions: The collection#show page seems a bit dull with two equal width big boxes on top. It seems to look prettier if I used 7 and 5 for the “details” and “sharing” panels respectively. Please update if you agree. If you like it the way it is, no big deal.

Updated! It makes more sense the way you said.

[...]

• Three tests in test/integration_performance/collections_perf_test.rb are failing for me. It may be because of my home network, but can you please double check. If they pass for you, all is good.

They didn't pass, I've fixed them now.

• In collections_controller.rb -> @is_persistent does not seem to be used anywhere anymore. Can you please remove this if no test failures? Thanks.

Removed and tested, all OK!

Commited at f6a485f

Thanks!

LGTM. Thanks.