Project

General

Profile

Actions

Bug #9932

closed

[CWL] Document best practices

Added by Peter Amstutz about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-

Subtasks 1 (0 open1 closed)

Task #9943: Review 9932-cwl-styleResolvedBryan Cosca09/06/2016Actions
Actions #1

Updated by Peter Amstutz about 8 years ago

  • Assigned To set to Peter Amstutz
Actions #2

Updated by Bryan Cosca about 8 years ago

L7:"CWL workflow best practices library":https://github.com/common-workflow-language/workflows and "dockstore":http://dockstore.org

L11: Avoid s/including/declaring/ @InlineJavascriptRequirement@ (nitpicky but it follows you saying declare in L9)

L43: Similarly, you can get the designated output directory using $(runtime.outdir).

L79: Don't s/specifying/specify/ resource

L109: has to s/complete/wait/ for all samples to complete before @step2@ can start +computing+ on any samples.

L134: Instead, scatter over a subworkflow.  In this pattern, a sample can proceed -from- to @step2@ as soon as @step1@ is done, independently of any other samples. The subworkflow can also be put in a separate CWL workflow file.
Example:

otherwise LGTM. We can add new things later when we think of them.

Actions #3

Updated by Peter Amstutz about 8 years ago

  • Status changed from New to Resolved

Applied in changeset arvados|commit:5aaaed7d7b1287c0133dd66c9492d6df62790288.

Actions

Also available in: Atom PDF