Idea #9950
closedarv-git-httpd config file & systemd unit
Updated by Tom Morris over 8 years ago
- Assigned To set to Tom Morris
- Target version set to Arvados Future Sprints
Updated by Tom Morris over 8 years ago
- Target version changed from Arvados Future Sprints to 2016-09-28 sprint
Updated by Tom Morris over 8 years ago
- Assigned To changed from Tom Morris to Tom Clegg
Updated by Nico César about 8 years ago
test de6dd658e9b1f27f7895337dc20195c0419799be
services/arv-git-httpd/arv-git-httpd.service LGTM
Is there any way to propagete HOST INSECURE to the arvadosclient library that isn't a ENV variable? I'm referring to:
+ os.Setenv("ARVADOS_API_HOST_INSECURE", "1")
this also seem to be doing for every setup of the client, is that once per slot on the ClientPool or is every time a interaction with API server starts?
Updated by Tom Clegg about 8 years ago
I certainly want to fix the arvadosclient library so it doesn't require env vars. I started addressing this in #9955 but ClientPool also needs to be updated.
Perhaps I should merge 9955 [into master, then] into 9950, and fix ClientPool so it either reads the env vars only once (for old code) or not at all (for new code that passes config explicitly).
Updated by Tom Clegg about 8 years ago
Updated ClientPool to avoid env vars → d8574bc
Updated by Nico César about 8 years ago
test d8574bcf0fa8577f893a3ae0431b6b3845896656
things look much better without global vars ;)
ready to merge
Updated by Tom Clegg about 8 years ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
Applied in changeset arvados|commit:9e27ddfd2f2538ff2216d75c450aa72dd3bc1cf8.