Story #9950

arv-git-httpd config file & systemd unit

Added by Peter Amstutz over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/21/2016
Due date:
% Done:

50%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #10075: config fileClosedNico César

Task #10071: Review 9950-arv-git-httpd-configResolvedNico César

Associated revisions

Revision 9e27ddfd
Added by Tom Clegg over 4 years ago

Merge branch '9950-arv-git-httpd-config' closes #9950

History

#1 Updated by Tom Morris over 4 years ago

  • Assigned To set to Tom Morris
  • Target version set to Arvados Future Sprints

#2 Updated by Tom Morris over 4 years ago

  • Target version changed from Arvados Future Sprints to 2016-09-28 sprint

#3 Updated by Tom Morris over 4 years ago

  • Assigned To changed from Tom Morris to Tom Clegg

#4 Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress

#5 Updated by Nico César over 4 years ago

test de6dd658e9b1f27f7895337dc20195c0419799be

services/arv-git-httpd/arv-git-httpd.service LGTM

Is there any way to propagete HOST INSECURE to the arvadosclient library that isn't a ENV variable? I'm referring to:

+               os.Setenv("ARVADOS_API_HOST_INSECURE", "1")

this also seem to be doing for every setup of the client, is that once per slot on the ClientPool or is every time a interaction with API server starts?

#6 Updated by Tom Clegg over 4 years ago

I certainly want to fix the arvadosclient library so it doesn't require env vars. I started addressing this in #9955 but ClientPool also needs to be updated.

Perhaps I should merge 9955 [into master, then] into 9950, and fix ClientPool so it either reads the env vars only once (for old code) or not at all (for new code that passes config explicitly).

#7 Updated by Tom Clegg over 4 years ago

Updated ClientPool to avoid env vars → d8574bc

#8 Updated by Nico César over 4 years ago

test d8574bcf0fa8577f893a3ae0431b6b3845896656

things look much better without global vars ;)

ready to merge

#9 Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:9e27ddfd2f2538ff2216d75c450aa72dd3bc1cf8.

Also available in: Atom PDF