Story #9954

keep-balance systemd unit

Added by Peter Amstutz over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/19/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #10072: Review 9954-keep-balance-systemdResolvedTom Clegg

Associated revisions

Revision d9eec0b9
Added by Tom Clegg over 4 years ago

Merge branch '9954-keep-balance-systemd' closes #9954

History

#1 Updated by Tom Clegg over 4 years ago

  • Subject changed from keep-balance config file & systemd unit to keep-balance systemd unit

#2 Updated by Tom Clegg over 4 years ago

Suggested unit file (keep-balance.service):

[Unit]
Description=Arvados Keep Balance
Documentation=https://doc.arvados.org/
After=network.target

[Service]
Type=simple
ExecStart=/usr/bin/keep-balance -config /etc/arvados/keep-balance/config.json -commit-pulls -commit-trash
Restart=always
RestartSec=10s

[Install]
WantedBy=multi-user.target

#3 Updated by Tom Morris over 4 years ago

  • Target version set to 2016-09-28 sprint

#4 Updated by Tom Clegg over 4 years ago

  • Assigned To set to Tom Clegg

#5 Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress

#6 Updated by Tom Clegg over 4 years ago

9954-keep-balance-systemd @ 17e4fbd

#7 Updated by Tom Clegg over 4 years ago

Is it a good idea to enable "-commit -pull" flags in the systemd file?
  • Yes - we're trying to avoid manual intervention (customizing systemd files) before things actually work
  • No - maybe requiring manual intervention is good thing in this particular case, and the default should be "test-only"

I went with "yes" because manual intervention (create a config file with API host and privileged token) is already necessary in order for keep-balance to do anything. If we change the default in the future from "test-only" to "really do it", existing systems that have config files (but are still running in "test-only" mode) will start running in "really do it" mode by themselves after a package update, which sounds undesirable.

#8 Updated by Nico C├ęsar over 4 years ago

test 17e4fbd0495b595b5cd959b389798201bebe8929

I reviewed services/keep-balance/keep-balance.service. It's ready to merge.

About the "yes"/"no" decision expressed in #9954#note-7 :

My take is a yes, it's a good idea, both for the undesirable future change on behavior and the fact that you install packages to actually do things.

commit-pulls isn't as dangerous as commit-trash. but I still think that yes. is a good idea to include it.

#9 Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:d9eec0b9bf52b428b5506617590d87b2d92eb246.

Also available in: Atom PDF