Arvados

Suggested unit file (keep-balance.service):

[Unit]
Description=Arvados Keep Balance
Documentation=https://doc.arvados.org/
After=network.target

[Service]
Type=simple
ExecStart=/usr/bin/keep-balance -config /etc/arvados/keep-balance/config.json -commit-pulls -commit-trash
Restart=always
RestartSec=10s

[Install]
WantedBy=multi-user.target

9954-keep-balance-systemd @ 17e4fbd

• Yes - we're trying to avoid manual intervention (customizing systemd files) before things actually work
• No - maybe requiring manual intervention is good thing in this particular case, and the default should be "test-only"

I went with "yes" because manual intervention (create a config file with API host and privileged token) is already necessary in order for keep-balance to do anything. If we change the default in the future from "test-only" to "really do it", existing systems that have config files (but are still running in "test-only" mode) will start running in "really do it" mode by themselves after a package update, which sounds undesirable.

test 17e4fbd0495b595b5cd959b389798201bebe8929

I reviewed services/keep-balance/keep-balance.service. It's ready to merge.

About the "yes"/"no" decision expressed in #9954#note-7 :

My take is a yes, it's a good idea, both for the undesirable future change on behavior and the fact that you install packages to actually do things.

commit-pulls isn't as dangerous as commit-trash. but I still think that yes. is a good idea to include it.