Arvados

9964-output-glob-acr @ 59ac77450a978b8bcfcbfdcc01b191ea91a2bc86

developer-run-tests: #4274

• All agreed upon points are implemented / addressed.
  • Translates CWL outputBinding->glob to output_glob
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • One corner case came up in development. If both outputBinding glob and cwl.output.json are used in the same CommandLineTool and cwl.output.json refers to files that don't match any globs, those files won't be uploaded. This situation cannot be detected automatically, but also may not be something that ever appears in practice. I discuss this in a comment.
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • added a unit test and ran the CWL 1.2 test suite
• Documentation has been updated.
  • improves the implementation of existing CWL functionality, doesn't require any documentation changes.
• Behaves appropriately at the intended scale (describe intended scale).
  • will improve performance in situations where there are a lot of files in the working directory and only a small subset are considered output by the workflow, by excluding those extra files from the output collection
• Considered backwards and forwards compatibility issues between client and server.
  • Updated the discovery doc revision to 20240502 (this is the date the output_glob feature was merged, it really should have been updated then) and made the feature conditional on the API server advertising the minimum version
• Follows our coding standards and GUI style guidelines.
  • yes

Not sure why this is failing, re-run:

developer-run-tests: #4276

9964-output-glob-acr @ 917e8925b29567a9324988767667235d5540f878

developer-run-tests: #4278

9964-output-glob-acr @ 9364cbd0174e9fd8f4394721ff575c59f8d42ff1

Fixed some tests

developer-run-tests: #4280

This LGTM, thanks.