Project

General

Profile

Actions

Bug #9970

closed

[Crunch2][API] ContainerRequest#Create passing with illegal requesting_container_uuid value(s).

Added by Radhika Chippada over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
API
Target version:
Story points:
0.5
Release:
Release relationship:
Auto

Description

During a container_request.create operation (1) either reset any requesting_container_uuid present in fill_field_defaults or (2) validate it in set_requesting_container_uuid.

API should always populate the requesting_container_uuid with either the requesting container's UUID (if the update/create request is not authorized by a per-container API token) or nil.


Subtasks 1 (0 open1 closed)

Task #10038: Review 9970-requesting-container-at-createResolvedRadhika Chippada09/14/2016Actions
Actions #1

Updated by Radhika Chippada over 7 years ago

  • Description updated (diff)
Actions #2

Updated by Tom Morris over 7 years ago

  • Target version set to Arvados Future Sprints
  • Story points set to 0.5
Actions #3

Updated by Tom Clegg over 7 years ago

  • Description updated (diff)
  • Target version deleted (Arvados Future Sprints)
  • Story points deleted (0.5)
Actions #4

Updated by Tom Clegg over 7 years ago

  • Category set to API
  • Target version set to Arvados Future Sprints
  • Story points set to 0.5
Actions #5

Updated by Radhika Chippada over 7 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
Actions #6

Updated by Lucas Di Pentima over 7 years ago

Do you think wouldn't be better than evaluating self.requesting_container_uuid twice, to do something like this?

if self.requesting_container_uuid
  not new_record?
end

Apart from that detail, LGTM.

Actions #7

Updated by Radhika Chippada over 7 years ago

  • Target version changed from Arvados Future Sprints to 2016-09-14 sprint
Actions #8

Updated by Radhika Chippada over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:849f35d1cafa1b58e55832426436689b95d69ac5.

Actions

Also available in: Atom PDF