Project

General

Profile

Bug #19981

Updated by Brett Smith about 1 year ago

*The Bug* 

 beagle.cwl has the resource requirement 
 <pre> 
   ResourceRequirement: 
     coresMin: 2 
     ramMin: 10000 
 </pre> 

 A new run: 
 https://workbench.2xpu4.arvadosapi.com/container_requests/2xpu4-xvhdp-ph1xry8mxbsol3j 

 An old run: 
 https://workbench.2xpu4.arvadosapi.com/container_requests/2xpu4-xvhdp-p571e0xq4g85ac7 

 The resource requirement didn't change, neither was keep_cache requirement specified. The recent run didn't reuse old run, since there is the following difference. 

 new runtime_constraints: 
 <pre> 
 keep_cache_disk 	 10485760000 
 keep_cache_ram 	 0 
 ram 	 10485760000 
 vcpus 	 2 
 </pre> 

 new node type: 
 <pre> 
 "ProviderType": "m5.8xlarge", 
 "VCPUs": 32, 
 "RAM": 137438953472, 
 "IncludedScratch": 4000000000, 
 "AddedScratch": 100000000000, 
 "Price": 1.542, 
 </pre> 

 old runtime_constraints: 
 <pre> 
 keep_cache_disk 	 0 
 keep_cache_ram 	 268435456 
 ram 	 10485760000 
 vcpus 	 2 
 </pre> 

 old node type: 
 <pre> 
 "ProviderType": "m5.xlarge", 
 "VCPUs": 4, 
 "RAM": 17179869184, 
 "IncludedScratch": 4000000000, 
 "AddedScratch": 0, 
 "Price": 0.192, 
 </pre> 

 *The Fix* 

 We want to fix this by unconditionally excluding the @keep_cache_ram@ and @keep_cache_disk@ runtime constraints from reuse considerations. A container's output really shouldn't be affected by these variables, similar to other inputs we've decided not to track by default like clock time. 

 Another reason to do this is avoid repeating this problem if we change the defaults again in the future, like just tweaking the numbers for default @keep_cache_disk@. 

 The container reuse documentation should be updated to reflect this change. 

Back