Bug #7181
Updated by Brett Smith over 8 years ago
Problem:
* If git is not installed on a compute node, the "egg_info" part of crunch-job's "install" script fails; fails to detect that the problem was that "git" was missing, and therefore fails to fall back to writing its own setup.cfg; and fails to provide any diagnostic info.
Current code:
<pre><code class="perl">
open(my $egg_info_pipe, "-|",
"python2.7 \Q$python_dir/setup.py\E --quiet egg_info 2>&1 >/dev/null");
my @egg_info_errors = <$egg_info_pipe>;
close($egg_info_pipe);
if ($?) {
if (@egg_info_errors and ($egg_info_errors[-1] =~ /\bgit\b/)) {
</code></pre>
Fix:
* Remove --quiet flag
* Extend the $egg_info_errors condition at the bottom of this block to catch the case where Git is not installed, and go into the following block to write a build tag to setup.cfg. (To figure out what this stderr looks like, take a .tar.gz of the Python SDK, and run @python setup.py egg_info@ from it on a host that does not have Git installed.) Remove @>/dev/null@