Project

General

Profile

Actions

Task #2602

closed

Feature #2376: Workbench should display collection tags everywhere it shows collection UUIDs

Review 2376

Added by Peter Amstutz about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Actions #1

Updated by Tim Pierce about 10 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Tim Pierce about 10 years ago

  • Assigned To set to Tim Pierce
Actions #3

Updated by Tim Pierce about 10 years ago

  • Assigned To changed from Tim Pierce to Peter Amstutz

Comments:

  • apps/workbench/app/views/layouts/application.html.erb
    • Remove commented out line?
  • apps/workbench/app/assets/javascripts/selection.js
    • Is this definitely all the sanitization we need? Would it make sense to replace <.*?>... or something similar?
  • apps/workbench/app/helpers/application_helper.rb
    • typo on line 178 (initial "1")
Actions #4

Updated by Peter Amstutz about 10 years ago

  • Removed old commented out line
  • This isn't intended to do sanitization, it is merely intended to clean up some text generated by a different part of workbench to be presentable in a different part of the UI that can't display formatted HTML (the x-editable selection list.) The x-editable list will actually display the text as <span>blahblah</span> if you leave the tags in so I don't think there is an attack vector there.
  • Fixed typo, good catch.
Actions #5

Updated by Peter Amstutz about 10 years ago

  • Assigned To changed from Peter Amstutz to Tim Pierce
Actions #6

Updated by Tim Pierce about 10 years ago

LGTM

Actions #7

Updated by Tim Pierce about 10 years ago

  • Assigned To changed from Tim Pierce to Peter Amstutz
Actions #8

Updated by Peter Amstutz about 10 years ago

  • Status changed from In Progress to Resolved
  • Remaining (hours) set to 0.0
Actions

Also available in: Atom PDF