Task #2714
closedIdea #2525: Generate a Java SDK using Google API tools
2525-java-sdk branch review
Updated by Radhika Chippada over 10 years ago
Please review the ArvadosSDKJavaUser java sample implementation and the README file to make sure it is clear to work with the SDK. Also, review the unit tests.
Updated by Peter Amstutz over 10 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz over 10 years ago
- Assigned To changed from Peter Amstutz to Radhika Chippada
Updated by Radhika Chippada over 10 years ago
- Assigned To changed from Radhika Chippada to Peter Amstutz
Peter,
I incorporated most of your suggestions and did some major respinning and refactoring.
Please review and let me know any further comments.
The following are still pending:
- Using a test server when running the unit tests.
I will add this in the next day or so.
I did add logic to remove any objects created by the tests.
2. Did not wrap "java -cp target/java-1.0-SNAPSHOT-jar . . . " in a script.
I felt it is important that the users know how to setup classpath to work with SDK,
and the updated documentation is making it easy enough to work with.
3. I have added several unit tests. I might add some more as time permits.
Let me know if you see any specific / important missing test cases.
Thanks.
--Radhika
Updated by Peter Amstutz over 10 years ago
- Assigned To changed from Peter Amstutz to Radhika Chippada
Updated by Radhika Chippada over 10 years ago
- Status changed from In Progress to Resolved
- Remaining (hours) set to 0.0
Addressed all feedback.