Project

General

Profile

Actions
Copy link

Bug #6430

closed

Migrate Google Spreadsheets code from OAuth1 to OAuth2

Added by Abram Connelly almost 9 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Third party integration
Target version:
-
Story points:
0.5

Description

Presumably OAuth1's disappearance explains why no survey responses have been imported since Feb. 2015.

https://developers.google.com/identity/protocols/OAuth_ref

Subtasks 4 (0 open — 4 closed)

Task #6449: Review 6430-surveys-oauth2ResolvedWard Vandewege06/25/2015Actions
Task #7032: review 6430-spreadsheets-oauth2 24a9314ResolvedWard Vandewege06/25/2015Actions
Task #6450: Use OAuth2 instead of OAuth1 to retrieve survey resultsResolvedTom Clegg06/25/2015Actions
Task #7290: Migrate GoogleSpreadsheet code from OAuth1 to OAuth2ResolvedTom Clegg06/25/2015Actions

Related issues

Related to Tapestry - Feature #4766: Upgrade oauth1 code for google doc/spreadsheet sync to oauth2ResolvedPhil Hodgson01/15/2015Actions
Actions
Copy link
 #1

Updated by Tom Clegg almost 9 years ago

  • Subject changed from Surveys haven't been updated since Feb. 2015 to Migrate Google Spreadsheets code from OAuth1 to OAuth2
  • Description updated (diff)
  • Category set to Third party integration
  • Story points set to 1.0
Actions
Copy link
 #2

Updated by Tom Clegg almost 9 years ago

  • Assigned To set to Tom Clegg
  • Target version set to 2015-07-08 sprint
Actions
Copy link
 #3

Updated by Tom Clegg almost 9 years ago

Notes on 6430-surveys-oauth2 @ 3900f65

  • It's possible to migrate existing grants from OAuth1 to OAuth2, but I didn't do that. AFAIK it would be more efficient for all affected users (researchers) to revoke and re-authorize. But if it turns out someone does need this, it can be added.
  • I didn't tackle the more generic GoogleSpreadsheet functionality here -- just the surveys -- but fixing the generic spreadsheets code shouldn't take much, now that the OAuth2 code is in place and there's the GoogleSurvey example to work from.
  • Instructions for setting up the OAuth service are already on the wiki (Set up an OAuth service).
  • I made some minor changes to the OpenHumans code in order to reuse the OAuth2 code that was already in place for OH. It could still stand to be cleaned up a bit more to simplify the admin's OAuth Service setup form, but I didn't want to turn this into an OH/OAuth refactoring story.
Refs
Actions
Copy link
 #4

Updated by Tom Clegg almost 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Brett Smith almost 9 years ago

  • Target version changed from 2015-07-08 sprint to 2015-07-22 sprint
Actions
Copy link
 #6

Updated by Tom Clegg almost 9 years ago

  • Story points changed from 1.0 to 0.5
Actions
Copy link
 #7

Updated by Ward Vandewege almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100
Actions
Copy link
 #8

Updated by Tom Clegg almost 9 years ago

  • Status changed from Resolved to In Progress
Two bugs addressed in updated 6430-surveys-oauth2 branch.
  1. Token refresh didn't work. Fixed in df5741c
  2. If one survey is unreadable, the "synchronize all" cron job crashes instead of just printing an error and moving on to the next survey. Fixed in c9a8ec6
Actions
Copy link
 #9

Updated by Tom Clegg almost 9 years ago

  • Target version changed from 2015-07-22 sprint to 2015-08-05 sprint
  • Story points changed from 0.5 to 0.0
Actions
Copy link
 #10

Updated by Tom Clegg almost 9 years ago

  • Target version changed from 2015-08-05 sprint to 2015-08-19 sprint
  • Story points changed from 0.0 to 0.5
Actions
Copy link
 #11

Updated by Tom Clegg almost 9 years ago

  • Assigned To changed from Tom Clegg to Ward Vandewege

Assigning to Ward because I expect most of the remaining work to be review+deploy.

Actions
Copy link
 #13

Updated by Ward Vandewege over 8 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #14

Updated by Tom Clegg over 8 years ago

  • Status changed from Resolved to In Progress

Reopening because there's still (non-survey-related) spreadsheet code that needs to be updated.

Actions
Copy link
 #15

Updated by Tom Clegg over 8 years ago

  • Assigned To changed from Ward Vandewege to Tom Clegg
Actions
Copy link
 #16

Updated by Brett Smith over 8 years ago

  • Target version changed from 2015-08-19 sprint to 2015-09-02 sprint
Actions
Copy link
 #17

Updated by Brett Smith over 8 years ago

  • Target version changed from 2015-09-02 sprint to 2015-09-16 sprint
Actions
Copy link
 #18

Updated by Ward Vandewege over 8 years ago

reviewing 6430-spreadsheets-oauth2 24a9314: tests pass, code looks good, LGTM.

Actions
Copy link
 #19

Updated by Tom Clegg over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 75 to 100
Actions
Copy link
 #20

Updated by Ward Vandewege over 4 years ago

  • Target version deleted (2015-09-16 sprint)
Actions
Copy link

Also available in: Atom PDF