Actions
Bug #20891
closedIncorrectly navigate to role group as project
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
Steps to reproduce:
- Navigate to a user that is a member of other groups
- Go to the "groups" tab
- Click on a group
You will be taken to a blank page under "shared with me" as if it were a project, when it should have navigated to the appropriate panel under "Groups".
Going to the "Members" of a group which is linked to other groups, and clicking on a group, exposes the same bug - the user navigates as if it were a project and not a role group.
Updated by Peter Amstutz over 1 year ago
- Description updated (diff)
- Subject changed from Incorrectly navigate to group as project to Incorrectly navigate to role group as project
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Updated by Lisa Knox over 1 year ago
All items finished - Waiting for cypress fixes in 15768 to be merged.
Updated by Lisa Knox over 1 year ago
developer-tests-workbench2: #1352
- All agreed upon points are implemented / addressed.
- done
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Manually navigated from user to group several times
- Documentation has been updated.
- N/A
- Behaves appropriately at the intended scale (describe intended scale).
- N/A
- Considered backwards and forwards compatibility issues between client and server.
- N/A
- Follows our coding standards and GUI style guidelines.
- done
Updated by Stephen Smith over 1 year ago
For the future it would be nice to split out formatting changes into a separate commit so it's easier to review the changes
Just one minor fix:
- One caveat with kind === group is that both user groups, projects, and virtual projects are "kind === group", so those are differentiated by the groupClass property which is
GroupClass.ROLE
for role (user) groups - you can see that property used on line 516 so you'll just need to include a check for that to make sure project resources use the regular navigateTo method. - There's an unused getUserUuid import warning that we might as well remove while we're here
Once that's done I think it lgtm and you can merge
Updated by Anonymous over 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|c30fc0c76112671804c2bab41c561f1a6f381920.
Actions