Project

General

Profile

Actions

Bug #20891

closed

Incorrectly navigate to role group as project

Added by Peter Amstutz 9 months ago. Updated 9 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

Steps to reproduce:

  1. Navigate to a user that is a member of other groups
  2. Go to the "groups" tab
  3. Click on a group

You will be taken to a blank page under "shared with me" as if it were a project, when it should have navigated to the appropriate panel under "Groups".

Going to the "Members" of a group which is linked to other groups, and clicking on a group, exposes the same bug - the user navigates as if it were a project and not a role group.


Subtasks 1 (0 open1 closed)

Task #20958: Review 20891-incorrect-navigate-to-groupResolvedStephen Smith09/28/2023Actions
Actions #1

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
  • Subject changed from Incorrectly navigate to group as project to Incorrectly navigate to role group as project
Actions #2

Updated by Peter Amstutz 9 months ago

  • Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Actions #3

Updated by Peter Amstutz 8 months ago

  • Assigned To set to Lisa Knox
Actions #4

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Actions #5

Updated by Lisa Knox 8 months ago

All items finished - Waiting for cypress fixes in 15768 to be merged.

Actions #6

Updated by Lisa Knox 8 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Lisa Knox 8 months ago

developer-tests-workbench2: #1352

  • All agreed upon points are implemented / addressed.
    • done
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Manually navigated from user to group several times
  • Documentation has been updated.
    • N/A
  • Behaves appropriately at the intended scale (describe intended scale).
    • N/A
  • Considered backwards and forwards compatibility issues between client and server.
    • N/A
  • Follows our coding standards and GUI style guidelines.
    • done
Actions #8

Updated by Stephen Smith 7 months ago

For the future it would be nice to split out formatting changes into a separate commit so it's easier to review the changes

Just one minor fix:

  • One caveat with kind === group is that both user groups, projects, and virtual projects are "kind === group", so those are differentiated by the groupClass property which is GroupClass.ROLE for role (user) groups - you can see that property used on line 516 so you'll just need to include a check for that to make sure project resources use the regular navigateTo method.
  • There's an unused getUserUuid import warning that we might as well remove while we're here

Once that's done I think it lgtm and you can merge

Actions #9

Updated by Anonymous 7 months ago

  • Status changed from In Progress to Resolved
Actions #10

Updated by Peter Amstutz 9 days ago

  • Release set to 67
Actions

Also available in: Atom PDF