Task #2581
closed
Idea #1776: User receives automatic email notification when account gets activated
Review 1776 implementation
Added by Radhika Chippada about 10 years ago.
Updated about 10 years ago.
Assigned To:
Radhika Chippada
The email related work is straightforward.
To add themes_for_rails to services/api, in addition to repeating the steps in workbench, I also had to add the following statement to the "application_controller.rb" : include ThemesForRails::ActionController
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
The code looks good to me here. Nice tests.
- services/api/config/application.default.yml
- I'd like to ensure that Arvados doesn't accidentally send mail notifications with a bogus domain like example.com. Does the email domain for
admin_notifier_email_from
and user_notifier_email_from
get changed somewhere? Or are we simply relying on the admin to change it to something useful manually when they configure Arvados?
According to Ward, these will be configured to the correct / desired values in production.
Radhika Chippada wrote:
According to Ward, these will be configured to the correct / desired values in production.
OK, I'll follow up on that separately, but this LGTM. Feel free to merge and close the issues :-)
Tim reviewed and approved of the changes.
- Status changed from In Progress to Resolved
- Remaining (hours) set to 0.0
Tim reviewed the code updates.
Also available in: Atom
PDF