Project

General

Profile

Actions

Feature #9570

closed

[CWL] Support CWL v1.0

Added by Peter Amstutz about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-

Subtasks 1 (0 open1 closed)

Task #9608: Review 9570-cwl-runner-fixesResolvedNico César07/15/2016Actions

Related issues

Related to Arvados - Bug #9567: [Tests] [CWL] Fix Jenkins buildResolvedActions
Actions #1

Updated by Nico César about 8 years ago

reviewed the code

and triggered https://ci.curoverse.com/job/developer-test-job/136/

I saw no new tests in that branch. are they anywhere else?

also: the failing package build still there. https://ci.curoverse.com/job/build-packages-debian7/203/

but with a different problem (like the .deb package for cwlrunner for example)

Actions #2

Updated by Nico César about 8 years ago

so when we build the packages we need to update the version in run-build-packages.sh too. This is my patch for cwltool

diff --git a/build/run-build-packages.sh b/build/run-build-packages.sh
index f2894e3..93df0b2 100755
--- a/build/run-build-packages.sh
+++ b/build/run-build-packages.sh
@@ -467,7 +467,7 @@ fpm_build schema_salad "" "" python 1.12.20160610104117
 fpm_build ruamel.yaml "" "" python 0.11.11 --python-setup-py-arguments "--single-version-externally-managed" 

 # And for cwltool we have the same problem as for schema_salad. Ward, 2016-03-17
-fpm_build cwltool "" "" python 1.0.20160630171631
+fpm_build cwltool "" "" python 1.0.20160712154127

 # FPM eats the trailing .0 in the python-rdflib-jsonld package when built with 'rdflib-jsonld>=0.3.0'. Force the version. Ward, 2016-03-25
 fpm_build rdflib-jsonld "" "" python 0.3.0

to avoid https://ci.curoverse.com/job/build-packages-debian7/203/

AND also there is a version of schema_salad to review there. Can you fill it in with the correct one too?

Thanks,

Actions #4

Updated by Peter Amstutz about 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:8af4c785ee48083eac92a0bd1ccd0bf4c41a9410.

Actions #5

Updated by Peter Amstutz about 8 years ago

  • Target version set to 2016-07-20 sprint
Actions #6

Updated by Peter Amstutz about 8 years ago

  • Status changed from Resolved to In Progress

Reopening for bug fixes.

Actions #7

Updated by Peter Amstutz about 8 years ago

  • Assigned To set to Peter Amstutz
Actions #8

Updated by Nico César about 8 years ago

test 0d4726056080f8c865135e0f576ccc15d4f388b9

I read the code in this ticket. the code didn't have any major issues, but It's hard for me to test this without deploying... how are you even testing this ?

Actions #9

Updated by Peter Amstutz about 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:5cf55ab0cfe55cbd803b61736276044f7008bfa4.

Actions

Also available in: Atom PDF