Actions
Idea #13627
closedUpdate a-c-r to newest cwltool
Start date:
06/19/2018
Due date:
Story points:
0.5
Release:
Release relationship:
Auto
Updated by Peter Amstutz over 6 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz over 6 years ago
- Subject changed from Update cwltool to Update a-c-r to newest cwltool
Updated by Peter Amstutz over 6 years ago
13627-update-cwltool @ 3bf756a35827ed8f7e0c18b5496031cdfeb8157e
https://ci.curoverse.com/job/developer-run-tests/757/
Running cwl test suite for crunch v1 / v2 tests in arvbox.
(note to self: run the arvados-specific test suite as well)
Updated by Peter Amstutz over 6 years ago
Yea, found a bug running the arvados-specific tests:
13627-update-cwltool 05fe77ea63bdbd7cc245301d2891f14456f2b5a0
Updated by Peter Amstutz over 6 years ago
Rebased on master
13627-update-cwltool @ 6f1a5b9cb0bc761115ef4bc31472ee47db83a906
Updated by Lucas Di Pentima over 6 years ago
Running sdk/cwl
tests locally y get this failure:
====================================================================== FAIL: test_run (tests.test_container.TestContainer) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/lucas/tmp/VENVDIR/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched return func(*args, **keywargs) File "/home/lucas/arvados_local/sdk/cwl/tests/test_container.py", line 111, in test_run 'secret_mounts': {} File "/home/lucas/tmp/VENVDIR/local/lib/python2.7/site-packages/mock/mock.py", line 935, in assert_called_with if expected != actual: File "/home/lucas/tmp/VENVDIR/local/lib/python2.7/site-packages/mock/mock.py", line 2200, in __ne__ return not self.__eq__(other) File "/home/lucas/tmp/VENVDIR/local/lib/python2.7/site-packages/mock/mock.py", line 2196, in __eq__ return (other_args, other_kwargs) == (self_args, self_kwargs) File "/home/lucas/arvados_local/sdk/cwl/tests/matcher.py", line 27, in __eq__ fromfile="Expected", tofile="Actual"))) AssertionError: *** Expected --- Actual *************** *** 19,25 **** "kind": "tmp" } }, ! "name": "test_run_True", "output_path": "/var/spool/cwl", "output_ttl": 0, "owner_uuid": "zzzzz-8i9sb-zzzzzzzzzzzzzzz", --- 19,25 ---- "kind": "tmp" } }, ! "name": "test_run_True_3", "output_path": "/var/spool/cwl", "output_ttl": 0, "owner_uuid": "zzzzz-8i9sb-zzzzzzzzzzzzzzz", ----------------------------------------------------------------------
Updated by Lucas Di Pentima over 6 years ago
Conformance tests passed OK on my side.
Updated by Peter Amstutz over 6 years ago
I can't reproduce that error but made a test tweak anyway on a guess. Running here:
Updated by Lucas Di Pentima over 6 years ago
Tried locally, and they went ok. LGTM, thanks!
Updated by Peter Amstutz over 6 years ago
- Target version changed from 2018-06-20 Sprint to 2018-07-03 Sprint
Updated by Tom Morris over 6 years ago
- Tracker changed from Bug to Idea
- Story points set to 0.5
Updated by Peter Amstutz over 6 years ago
- Status changed from In Progress to Resolved
Actions