Bug #22545
closed
Flaky workbench tests 2025-02 favorites.cy.js
Added by Tom Clegg 2 months ago.
Updated about 1 month ago.
Release relationship:
Auto
Description
run-tests-services-workbench2-integration: #151 
/console → favorites.cy.js
1) Favorites tests
shows the correct favorites and public favorites in the side panel:
AssertionError: Timed out retrying after 4000ms: expected '<div>' to contain 'Test favorite collection 466959'
at Context.eval (webpack://arvados-workbench-2/./cypress/e2e/favorites.cy.js:357:107)
run-tests-services-workbench2-integration: #154 
/console → favorites.cy.js
1) Favorites tests
shows the correct favorites and public favorites in the side panel:
AssertionError: Timed out retrying after 4000ms: expected '<div>' to contain 'myFavoriteProject1'
at Context.eval (webpack://arvados-workbench-2/./cypress/e2e/favorites.cy.js:344:107)
run-tests-services-workbench2-integration: #169 
/console → favorites.cy.js
1) Favorites tests
shows the correct favorites and public favorites in the side panel:
AssertionError: Timed out retrying after 4000ms: expected '<div>' to contain 'Test favorite collection 3223'
at Context.eval (webpack://arvados-workbench-2/./cypress/e2e/favorites.cy.js:357:107)
- Description updated (diff)
- Target version changed from Development 2025-02-12 to Development 2025-02-26
- Category set to Workbench2
- Assigned To set to Lisa Knox
22545-tests-25-02 @ 3743bfa21493d814822bac0930e32c2075d7ff32
developer-run-tests-services-workbench2: #1450 
- ✅ All agreed upon points are implemented / addressed.
- n/a - Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- passed testing suite at least 10 times locally, 5 times on Jenkins
- n/a - New or changed UX/UX and has gotten feedback from stakeholders.
- n/a - Documentation has been updated.
- ✅ Behaves appropriately at the intended scale (describe intended scale).
- ✅ Considered backwards and forwards compatibility issues between client and server.
- ✅ Follows our coding standards and GUI style guidelines.
Notes:
- The main problem here was that there were too many resources being created in a single test. Resources created during a test are cleaned up at the end of the test. If too many resources are created during a test, when an element is searched for in the DOM it might be scrolled off the screen. This also happens because when resources are created in previous tests without using the createResource command (e.g. manually clicking "+NEW PROJECT" etc.). They remain in the db and populate in all future tests.
- The solve was breaking the tests into smaller tests to allow for better automatic resource cleanup.
Just a single nit but otherwise looks good!
- There is a stray console.log in favorites.cy.js
- Status changed from New to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by