Project

General

Profile

Actions

Task #3422

closed

Idea #2769: [Keep] Keep supports DELETE requests

Review 2769-keep-delete-request

Added by Tim Pierce over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Misha Zatsman
Target version:

Description

Review @ b9d9b77

This branch implements basic DELETE support for Keep:

The DeleteHandler method implements DELETE requests for Keep, checking that the user is authorized to issue DELETE and then deleting the requested block from local volumes.

  • CanDelete checks that the user with the given token is authorized to delete blocks from Keep.
  • MockVolume and UnixVolume objects provide a Delete method for deleting a block from that volume.
  • TestDeleteHandler tests:
    • Unauthenticated requests
    • Requests from a non-admin user
    • Requests from a non-admin user for a nonexistent block
    • Requests from a non-admin user for an existing block
Actions

Also available in: Atom PDF