Bug #10243
closed
[PySDK] Enable the Collection file packing feature by explicit flag
Added by Lucas Di Pentima about 8 years ago.
Updated about 8 years ago.
Description
Pass an optional flush=False to ArvadosFileWriter.close() to tell the SDK to pack small files, keeping the feature disabled by default to doesn't confuse FUSE.
- Subject changed from Enable the Collection file packing feature by explicit flag to [PySDK] Enable the Collection file packing feature by explicit flag
- Status changed from New to In Progress
Looks like builds 24 and 25 both failed on an unrelated(?) flaky test #10008.
FUSE tests pass for me as well.
I think it would be good to have a test in sdk/python that ensures close() (without flush=False) causes short blocks to be committed. Currently it seems like we are relying on FUSE integration test tests.test_mount.FuseModifyFileTest
to catch that.
With that, e86904a LGTM, thanks.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:2656053035f46e6097b380f5c0da7d54b04a60c4.
Also available in: Atom
PDF