Bug #13934
closedadd code comment to avoid reversion of 13788
Description
While working on 13933, I inadvertently reverted the concurrent map access bug that was fixed in 13788 (by moving the list var declaration out of the loop so that I could use it for the initial `limit: 0` `count: exact` call).
I would suggest adding a comment to the var declaration to make a particular point of it being absolutely necessary to declare it afresh in each loop iteration, as I suspect it would otherwise be likely that the same mistake will be made again.
Updated by Tom Clegg over 6 years ago
- Assigned To set to Tom Clegg
- Target version set to 2018-08-15 Sprint
Updated by Tom Clegg over 6 years ago
13934-guard-comment @ c4e13fdbb3f7de9d587f9c07b4711c08c7eae09e
Updated by Tom Morris over 6 years ago
LGTM
(I was going to suggest that replacing the colon with a period/full stop was more grammatically correct, but then thought that might be considered bikeshedding (or is it bike-shedding?)) ;-)
Updated by Tom Clegg over 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|f4faf6f01860cb4683536a2c5e793a93b4193a42.