Bug #16086
closed
- Subject changed from always says "There are no inputs" when trying to display inputs to always says "There are no inputs" when trying display inputs to a process
- Description updated (diff)
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
Updates at commit 874af8e3 - branch 16086-no-inputs-fix
Fixed an error I made on commit c5fa0c4eed while working on #15407.
Also fixed an issue when displaying start/finish dates.
Now when I try to select "inputs" I get a crash page:
TypeError: values.map is not a function
./src/components/chips/chips.tsx/Chips.prototype.render
src/workbench2/src/components/chips/chips.tsx:32
29 | render() {
30 | const { values, filler } = this.props;
31 | return <Grid container spacing={8} className={this.props.classes.root}>
> 32 | {values.map(this.renderChip)}
33 | {filler && <Grid item xs>{filler}</Grid>}
34 | </Grid>;
35 | }
Updates at commit cb148df5 ready for review.
- Target version changed from 2020-02-12 Sprint to 2020-01-29 Sprint
value: data.mounts[MOUNT_PATH_CWL_INPUT].content[it.id.split('#main/')[1]] || [],
That's not quite right. You should split on '/' and then take the last element.
Fixed at commit a94a57d2, thanks!
Lucas Di Pentima wrote:
Fixed at commit a94a57d2, thanks!
Now that it works I see the existing user interface is a little weird but that's a separate story, this LGTM!
- Status changed from In Progress to Resolved
Also available in: Atom
PDF