Bug #17601
closed
[deployment][arvados-formula] webshell needs a cron for login-sync
Added by Javier Bértoli over 3 years ago.
Updated over 3 years ago.
Assigned To:
Javier Bértoli
Release relationship:
Auto
Description
The formula is adding the login-sync gem, but not a cron to run it every two minutes. We need to add
# SALT_CRON_IDENTIFIER:arvados_login_sync
*/2 * * * * /usr/local/bin/arvados-login-sync
Shell node needs to be registered to API to run the script, so that needs to be fixed before this ticket.
- Status changed from New to In Progress
- Blocked by Feature #17607: [deployment][provision][arvados-formula] register shell nodes with Arvados added
- Status changed from In Progress to New
- Description updated (diff)
- Target version changed from 2021-05-12 sprint to 2021-05-26 sprint
- Status changed from New to In Progress
Added an example of some crude orchestration to get a shell node's scoped token and vm uuid and add them in a cron for arvados-login-sync.
As these tasks require orchestration (api server must be running before these queries being possible), I added them as examples, as they're useless on a single node configuration (which is the scope of a salt formula)
commit 4040230@arvados-formula, branch 17607-register-shell-nodes.
Need testing
- Target version changed from 2021-05-26 sprint to 2021-06-09 sprint
- Status changed from In Progress to Feedback
Some more fixes (squashed, sorry. Habit :| )
The cron is provided as an example state.
commit:e6dace0|arvados-formula, branch 17607-register-shell-nodes
- File
test/salt/states/examples/arvados/shell/cron/add-login-sync.sls - Line 50: The grep execution on the unless clause of the example relies on the cluster prefix to be fixme instead of just a 5 alphanum string.
- Is there a way to properly test these examples (via jenkins, or manually)? I feel that just reading the code isn't enough to catch issues.
The rest LGTM
Lucas Di Pentima wrote:
- File
test/salt/states/examples/arvados/shell/cron/add-login-sync.sls - Line 50: The grep execution on the unless clause of the example relies on the cluster prefix to be fixme instead of just a 5 alphanum string.
fixed commit:b47321d|arvados-formula
- Is there a way to properly test these examples (via jenkins, or manually)? I feel that just reading the code isn't enough to catch issues.
Not yet. These changes require orchestration, which I haven't set up yet in jenkins
- Blocked by deleted (Feature #17607: [deployment][provision][arvados-formula] register shell nodes with Arvados)
- Status changed from Feedback to Resolved
Also available in: Atom
PDF
Updated by 
Updated by Javier Bértoli 
Updated by