Arvados

21585-installer-imdsv2 @ f10e92fe09

• All agreed upon points are implemented / addressed.
  • Yes
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • No
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Have already applied this on running clusters. The change is trivial and doesn't modify existing cloud resources in a way that they need to be recreated.
• Documentation has been updated.
  • No. This is implemented as default (although manually overridable by people who can read Terraform code). Being that IMDSv2 is a feature that exists for around 3 years and it's recommended for security reasons by AWS, I don't see the point of documenting it if there's no apparent reason to disable it.
• Behaves appropriately at the intended scale (describe intended scale).
  • N/A
• Considered backwards and forwards compatibility issues between client and server.
  • N/A
• Follows our coding standards and GUI style guidelines.
  • Yes

Lucas Di Pentima wrote in #note-5:

21585-installer-imdsv2 @ f10e92fe09

LGTM, thank you.