Project

General

Profile

Actions

Bug #21893

closed

list of input collections on process panel should use virtualized list

Added by Peter Amstutz 5 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release:
Release relationship:
Auto

Description

This is the tab under "Inputs" that lists the contents of "mounts" as a table.


Subtasks 1 (0 open1 closed)

Task #21985: Review 21893-input-collections-virtual-listResolvedStephen Smith09/17/2024Actions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2024-07-03 sprint to Development 2024-07-24 sprint
Actions #3

Updated by Peter Amstutz 5 months ago

  • Release set to 70
Actions #4

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Stephen Smith
Actions #5

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-07-24 sprint to Development 2024-08-07 sprint
Actions #6

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-08-07 sprint to Development 2024-08-28 sprint
Actions #7

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-08-28 sprint to Development 2024-09-11 sprint
Actions #8

Updated by Peter Amstutz 2 months ago

  • Target version changed from Development 2024-09-11 sprint to Development 2024-09-25 sprint
Actions #9

Updated by Stephen Smith 2 months ago

  • Status changed from New to In Progress
Actions #10

Updated by Stephen Smith 2 months ago

Changes at arvados|b220283a4a532ca37a9f1f74ddcab93dffe828cc branch 21893-input-collections-virtual-list
Tests developer-run-tests-services-workbench2: #1140

  • All agreed upon points are implemented / addressed.
    • Implement virtual list for process io card input collections tab
    • Add separate custom column width styles for collection input table
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • tested manually by injecting 400,000 rows
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • Up to ~400 rows or until virtual list scrolling breaks
  • Considered backwards and forwards compatibility issues between client and server.
    • none
  • Follows our coding standards and GUI style guidelines.
    • no significant design changes
Actions #11

Updated by Lucas Di Pentima 2 months ago

Code updates LGTM, my only suggestion (unrelated to this ticket) is to keep the linter happy:

WARNING in [eslint]
src/store/processes/processes-actions.ts
  Line 9:10:   'Process' is defined but never used                   @typescript-eslint/no-unused-vars
  Line 24:10:  'ContainerResource' is defined but never used         @typescript-eslint/no-unused-vars
  Line 25:10:  'ContainerRequestResource' is defined but never used  @typescript-eslint/no-unused-vars

src/store/workbench/workbench-actions.ts
  Line 50:13:  'processesActions' is defined but never used  @typescript-eslint/no-unused-vars

src/views-components/context-menu/actions/helpers.ts
  Line 5:10:   'REDIRECT_TO_DOWNLOAD_KEY' is defined but never used  @typescript-eslint/no-unused-vars
  Line 5:36:   'REDIRECT_TO_PREVIEW_KEY' is defined but never used   @typescript-eslint/no-unused-vars
  Line 19:12:  'uuid' is assigned a value but never used             @typescript-eslint/no-unused-vars

src/views/process-panel/process-details-attributes.tsx
  Line 13:10:   'Process' is defined but never used  @typescript-eslint/no-unused-vars
  Line 137:40:  Expected '===' and instead saw '=='  eqeqeq

src/views/run-process-panel/run-process-advanced-form.tsx
  Line 14:10:  'PROCESS_NAME_VALIDATION' is defined but never used  @typescript-eslint/no-unused-vars
Actions #12

Updated by Stephen Smith 2 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF