Project

General

Profile

Actions
Copy link

Bug #22509

closed

upgrade golang to 1.23

Added by Peter Amstutz 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
Development 2025-02-26
Story points:
-
Release:
Arvados 3.1.0
Release relationship:
Auto

Description

According to Tom:

"If we tell go.mod that we expect to build with 1.22.4 or later, go will download and use the correct version for us"

Subtasks 2 (0 open — 2 closed)

Task #22583: Review 22509-go1224ResolvedLucas Di Pentima02/14/2025Actions
Task #22585: Review 22509-go1236ResolvedLucas Di Pentima02/14/2025Actions
Actions
Copy link
 #1

Updated by Peter Amstutz 2 months ago

  • Position changed from -937206 to -937194
Actions
Copy link
 #2

Updated by Peter Amstutz about 2 months ago

  • Target version changed from Development 2025-02-12 to Development 2025-02-26
Actions
Copy link
 #3

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Tom Clegg about 2 months ago

22509-go1224 @ 5642c8a7416185661bfa3bd952b27efb23011d8d -- just changes the version number in go.mod, lib/install/deps.go, and ansible. This should cause the existing jenkins workers to download Go 1.22.4 and compile/test everything with that version.

If this works, then we can safely update the jenkins worker image to Go 1.22.4, and merge this branch.

After we update the jenkins worker image, when we package/test old versions of arvados, Go will likewise download Go 1.21.10 and use that to build/test.

Actions
Copy link
 #5

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Tom Clegg
  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Tom Clegg about 2 months ago

22509-go1224 @ 2ccf04510adb7904e26b7944ce5fb35d1d4ae4f4 -- developer-run-tests: #4662

This failed a flaky workbench2 integration test but passed everything else.

go: go: downloading go1.22.4 (linux/amd64)
go version go1.22.4 linux/amd64

After merging this we do need to update the jenkins worker image, otherwise we'll re-download Go on every test run.

Actions
Copy link
 #7

Updated by Tom Clegg about 2 months ago

  • Subtask #22583 added
Actions
Copy link
 #8

Updated by Lucas Di Pentima about 2 months ago

This toolchain download feature is really handy. LGTM.

Actions
Copy link
 #9

Updated by Tom Clegg about 2 months ago

  • Assigned To changed from Tom Clegg to Lucas Di Pentima
Actions
Copy link
 #10

Updated by Tom Clegg about 2 months ago

  • Assigned To changed from Lucas Di Pentima to Brett Smith
Actions
Copy link
 #11

Updated by Tom Clegg about 2 months ago

  • Assigned To changed from Brett Smith to Tom Clegg
Actions
Copy link
 #13

Updated by Tom Clegg about 2 months ago

  • Subtask #22585 added
Actions
Copy link
 #14

Updated by Tom Clegg about 2 months ago

  • Subject changed from upgrade golang to 1.21.11 or 1.22.4 to upgrade golang to 1.23
Actions
Copy link
 #15

Updated by Lucas Di Pentima about 2 months ago

22509-go1236 also LGTM, thanks.

Actions
Copy link
 #16

Updated by Brett Smith about 1 month ago

Tom Clegg wrote in #note-6:

After merging this we do need to update the jenkins worker image, otherwise we'll re-download Go on every test run.

Pending in #22579#note-8.

Actions
Copy link
 #17

Updated by Brett Smith about 1 month ago

I merged the Go 1.23 branch, built a new image from it, and it's being used for new test runs. developer-run-tests: #4668

With that I believe this ticket is resolved but I'll let Tom make the final call.

Actions
Copy link
 #18

Updated by Peter Amstutz about 1 month ago

  • Release set to 75
Actions
Copy link
 #19

Updated by Tom Clegg about 1 month ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF