Bug #10671
closed
[API Server] Fill in finish time when pipeline instance is marked with final state
Related issues
Updated by Tom Morris over 7 years ago
- Target version set to Arvados Future Sprints
- Story points set to 0.5
If the client provides no end time or it's null then the API server fills in the current time.
Updated by Tom Morris over 7 years ago
- Target version changed from Arvados Future Sprints to 2017-01-04 sprint
Updated by Lucas Di Pentima over 7 years ago
- Assigned To set to Lucas Di Pentima
Updated by Lucas Di Pentima over 7 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 7 years ago
Test run: https://ci.curoverse.com/job/developer-run-tests/111/ (test run 110 failed on sdk/python but didn't on my local run, so re-running to see if it was just a temporary issue)
Updated: 4115524460e89f36b99f2fb5de1adebd86daaf4a
Added a before_save filter to PipelineInstance model to update started_at and finished_at dates when changing states.
Updated by Tom Clegg over 7 years ago
I think it would be good to ensure started_at isn't nil when changing state to Failed or Complete too, in case a client creates a new object with state=Complete.
I don't think it would affect anything in practice as things stand, but I think conceptually (and for the sake of our future selves) this should be before_validation rather than before_save -- e.g., if we were validating started_at and finished_at, we would want to validate after applying these defaults, not after.
other than those points, LGTM
Updated by Lucas Di Pentima over 7 years ago
Updates: 4f03b29b3efb42a48c3f397942d5b618b89390eb
Test running at https://ci.curoverse.com/job/developer-run-tests/114/
When the pipeline instances is finished (either completed or failed) and started_at is nil, it will have the exact same time as finished_at.
Updated by Lucas Di Pentima over 7 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:96d90c859cede094d83cbaf5409418e9ab0c2c19.