Arvados

Updates at 2ed8d670a - branch 19177-sharing-links-ui-config

• Adds an exported boolean config knob at Workbench.DisableSharingURLsUI in controller (false by default)
• Makes Workbench1 not show the Share/Unshare button & links when this config is set to true.
• Adds test.

Tests are failing (developer-run-tests: #3168 ), but not yet sure if it is because of these changes.

Updates at arvados-workbench2|e1e17729 - branch 19177-sharing-urls-ui-config
Test run: developer-tests-workbench2: #741

• Reads Workbench.DisableSharingURLsUI config from controller and hides the "Sharing URLs" tab on the collection's sharing dialog if needed.
• Also avoids making unnecessary requests for scoped tokens if Workbench.DisableSharingURLsUI is true.
• Adds unit tests.

Updates at d104886 (arvados repo)
Test run: developer-run-tests: #3170
Failed test re-run: developer-run-tests-apps-workbench-integration: #3398

• Fixes wb1's test assertions when checking for the "Create sharing link" button.

For Workbench2's tests, I had to run them against arvados' 40e378c commit, it seems there's some kind of issue on our Jenkins pipeline that causes the arvados-server run to fail after ~20 minutes when run against the current main.
Test run: developer-tests-workbench2: #744

Lucas Di Pentima wrote:

Updates at d104886 (arvados repo)
Test run: developer-run-tests: #3170
Failed test re-run: developer-run-tests-apps-workbench-integration: #3398

• Fixes wb1's test assertions when checking for the "Create sharing link" button.

For Workbench2's tests, I had to run them against arvados' 40e378c commit, it seems there's some kind of issue on our Jenkins pipeline that causes the arvados-server run to fail after ~20 minutes when run against the current main.
Test run: developer-tests-workbench2: #744

By only comment is that it's clearer for configuration items to enable things than to disable things, so "EnableSharingURLsUI" with default "true" is less confusing than having to set "true" to disable it. Although maybe there is a counter-argument is that it is better for "false" value to mean you want default behavior.

However either way I don't think it is worth going back and changing it, so this LGTM.