Project

General

Profile

Actions
Copy link

Bug #21278

closed

Redirect loop when refreshing search results

Added by Brett Smith about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Peter Amstutz
Category:
Workbench2
Target version:
Development 2024-01-17 sprint
Story points:
-
Release:
Arvados 2.7.2
Release relationship:
Auto

Description

Steps to reproduce:

  1. Search for something in Workbench
  2. Once you're on the results page, refresh the page in your browser

Expected result: The page refreshes and shows your results again

Actual result: The browser shows a built-in error page to report "This page isn't redirecting properly"

Subtasks 1 (0 open — 1 closed)

Task #21341: Review 21278-search-redirectResolvedPeter Amstutz01/03/2024Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Future to Development 2024-01-17 sprint
Actions
Copy link
 #2

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2024-01-17 sprint to Development 2024-01-31 sprint
Actions
Copy link
 #3

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2024-01-31 sprint to Development 2024-01-17 sprint
Actions
Copy link
 #4

Updated by Stephen Smith about 1 year ago

I noticed this doesn't happen locally, using curl -v it looks like the immediate response to any /search-results path gives a 302 redirect to the same url without sending any workbench code. This might be an nginx configuration issue

Actions
Copy link
 #5

Updated by Peter Amstutz about 1 year ago

  • Assigned To set to Peter Amstutz

Check if this is actually a bug in the nginx redirects for wb1 to wb2 paths.

Actions
Copy link
 #6

Updated by Tom Clegg about 1 year ago

Indeed, one of our redirect rules in source:sdk/python/tests/nginx.conf copied from source:tools/salt-install/config_examples/multi_host/aws/pillars/nginx_workbench_configuration.sls is

    ^/search.*                     /search-results;

...which is a redirect loop.

Actions
Copy link
 #7

Updated by Peter Amstutz about 1 year ago

21278-search-redirect @ a22d01b7133be84a38914ab98a19d4e5aba07d50

developer-run-tests: #3980

Just removes the redirect, it doesn't add enough value to try and make it work.

Actions
Copy link
 #8

Updated by Peter Amstutz about 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #9

Updated by Tom Clegg about 1 year ago

Agree, LGTM.

Actions
Copy link
 #10

Updated by Peter Amstutz about 1 year ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #11

Updated by Peter Amstutz about 1 year ago

  • Release set to 69
Actions
Copy link

Also available in: Atom PDF