Arvados

22224-clean-java-sdk @ 2b89a9b70223fddf992547d5bff778c183c2c50f - developer-run-tests-doc-sdk-java-R: #2230

• All agreed upon points are implemented / addressed.
  • After this branch, all of these searches under sdk/java-v2 return no relevant results:

    # Methods
    git grep -Ei -e '\b(destroy|index|show)\b'
    # Resources
    git grep -Ei '\bapi\.client\b' | grep -v ' org\.arvados\.client\.api\.client[;.]'
    git grep -Ei -e job -e pipeline -e node -e repositor -e human -e specimen -e trait
    # Attributes
    git grep -Ei -e user_id -e default_owner_uuid -e href -e next_link -e next_page_token -e 'self.?link'

• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • N/A
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • See above
• Documentation has been updated.
  • Confirmed the automated Javadoc reflects the changes.
• Behaves appropriately at the intended scale (describe intended scale).
  • No change in scale
• Considered backwards and forwards compatibility issues between client and server.
  • We're already committed to the backwards compatibility break at the Arvados API level, this just keeps everything consistent.
• Follows our coding standards and GUI style guidelines.
  • N/A (no change in style, didn't write any of my own code)

Brett Smith wrote in #note-3:

22224-clean-java-sdk @ 2b89a9b70223fddf992547d5bff778c183c2c50f - developer-run-tests-doc-sdk-java-R: #2230

• All agreed upon points are implemented / addressed.
  • After this branch, all of these searches under sdk/java-v2 return no relevant results:[...]
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • N/A
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • See above
• Documentation has been updated.
  • Confirmed the automated Javadoc reflects the changes.
• Behaves appropriately at the intended scale (describe intended scale).
  • No change in scale
• Considered backwards and forwards compatibility issues between client and server.
  • We're already committed to the backwards compatibility break at the Arvados API level, this just keeps everything consistent.
• Follows our coding standards and GUI style guidelines.
  • N/A (no change in style, didn't write any of my own code)

LGTM.