Actions
Bug #22400
closed
broken paging logic causes arvados-dispatch-cloud to hang at startup while looking up spot prices
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
We have
func (instanceSet *ec2InstanceSet) updateSpotPrices(instances []cloud.Instance) {
...
if page.NextToken == nil {
break
}
but the NextToken documentation is
// The token to include in another request to get the next page of items. This
// value is an empty string ( "" ) or null when there are no more items to return.
NextToken *string
The web docs also mention this.
Updated by Tom Clegg 5 days ago
Other similar structs in the AWS SDK (DescribeInstancesOutput, DescribeInstanceStatusOutput) do not allow the "" case:
// The token to include in another request to get the next page of items. This
// value is null when there are no more items to return.
NextToken *string
But "" isn't plausible as a "next page" token, so we should probably update our uses of those APIs too while we're at it.
Updated by Tom Clegg 5 days ago
22400-spot-price-paging @ 65b6d7ce672fa7d17619af0ebb7994931ed69d4f -- developer-run-tests: #4574
Updated by Tom Clegg 5 days ago
- Related to Bug #22402: arvados-dispatch-cloud should log warnings when cloud API calls are slow added
Updated by Tom Clegg 5 days ago
- Related to Bug #22401: crunch-run --list (with no additional args) should not read from stdin added
Updated by
Updated by Tom Clegg 4 days ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|d6d9ae636a0dd247f305ed62ac4e7b85a5f5cdb1.
Actions