Story #3490

[Workbench] Create and edit pipeline templates

Added by Peter Amstutz over 4 years ago. Updated 5 days ago.

Status:
Rejected
Priority:
Normal
Assigned To:
-
Category:
Workbench
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
2.0

Description

Goals:
  • Quicker to debug pipeline templates (if Workbench is used to run tests)
  • Friendlier validation (arv edit fails rudely if JSON syntax is wrong, and doesn't even notice any errors more subtle than that.)
Feature: "Edit components" tab in PipelineTemplate#view (when the current template is writable)
  • Textarea with components attribute in JSON format
  • "Save" button
  • Preview area (probably beside textarea)
  • "Update" button refreshes preview pane immediately (greyed out and disabled when already up-to-date or JSON is unparseable)
  • When textarea has changed since last AJAX request was initiated, and no input/click events have happened for (say) 1 second, update the preview pane:
    • Cancel any AJAX request in progress
    • If the textarea content is not parseable, disable the "Update" button, show an alert (class="alert alert-warning"?) to that effect, and stop
    • Grey out the "Update" button and change its text to "Updating..."
    • Start AJAX request for preview
Workbench server side
  • Add ApplicationController#preview method (and route put :preview, on: :member, just for pipeline instances for now) -- much like generic #update, but doesn't save.
  • Replace pipeline_templates/_show_chooser_preview.html.erb with something useful. It should look decent in this preview window and in the generic chooser / search dialog. (The current preview just defers to show_components and looks pretty bad.)

Related issues

Related to Arvados - Bug #4451: [Workbench] Fiddlesticks when rerunning pipeline with edited templateClosed2014-11-06

Related to Arvados - Feature #4712: [Crunch] Skip some components when running a pipelineNew2014-12-03

Related to Arvados - Story #2992: [Workbench] Support "display_order" (integer) key for pipeline template components. Obey when rendering pipeline summary/details in Workbench.Rejected2019-03-13

Has duplicate Arvados - Feature #5291: [Workbench] Editing pipeline templates on WorkbenchClosed2015-02-23

History

#1 Updated by Tom Clegg over 4 years ago

  • Subject changed from [Workbench] User should be able to create and edit pipeline templates in workbench instead of having switch back and forth between workbench and command line. to [Workbench] Create and edit pipeline template components in Workbench.
  • Description updated (diff)
  • Category set to Workbench
  • Story points set to 2.0

#2 Updated by Tom Clegg over 4 years ago

  • Target version set to Arvados Future Sprints

#3 Updated by Tom Clegg over 4 years ago

  • Description updated (diff)

#4 Updated by Peter Amstutz over 4 years ago

  • Target version changed from Arvados Future Sprints to 2015-01-07 sprint

#5 Updated by Peter Amstutz over 4 years ago

  • Target version changed from 2015-01-07 sprint to Arvados Future Sprints

#6 Updated by Tom Clegg over 4 years ago

  • Subject changed from [Workbench] Create and edit pipeline template components in Workbench. to [Workbench] Create and edit pipeline templates

#7 Updated by Brett Smith about 4 years ago

Bryan suggested http://json.parser.online.fr/ for inspiration in the related ticket.

#8 Updated by Tom Morris 5 days ago

  • Status changed from New to Rejected
  • Target version deleted (Arvados Future Sprints)

Pipeline templates haven't been a thing for a while

Also available in: Atom PDF