Arvados

Fix at 7d1970e46 - branch 16141-gosdk-missing-fields
Test run: developer-run-tests: #1720

• Adds missing collection fields from the RailsAPI on the GoSDK.
• Adds test comparing direct RailsAPI response against controller's.

If this is the correct testing approach, we could expand it to the other object types.

If this is the correct testing approach, we could expand it to the other object types.

Yes, this test (and expanding it to other types) looks like a good idea.

Why does the test avoid checking the controller response value when the Rails response value is nil? (Wouldn't the DeepEquals check still be fitting in this case?)

While we're here, does the converse test (new fields returned by controller that don't come from Rails) reveal anything interesting?

I don't think we should add "href". It seems to be broken in railsAPI anyway, currently reporting "/collections/$uuid".

version, file_count, and file_size_total are all "not null" in the database, so they should be int, not *int.

file_size_total should probably be int64, like file sizes elsewhere in Go (e.g., https://golang.org/pkg/os/#FileInfo).

Updates at ebd4760f0
Test run: developer-run-tests: #1722

• Addresses above suggestions ignoring the href field, and fixing some Collection type's field declarations.
• Expands test case to check for other object types.
• Fixes User's fixture and GoSDK type.

Added better failure message on 1da59913e

It seems that the keep_services' fixture is not loaded when running tests on Jenkins? The tests pass on my local dev env: developer-run-tests-remainder: #1789 /console

Fix on 484cf9fec
Test run: developer-run-tests-remainder: #1790

• Instead of using a keep_service fixture UUID, request the list of keep services to the test server and use the first.

Although description can be null in the database, null vs. "" doesn't seem like a meaningful distinction -- it can be a string rather than a *string.

Is there a reason why collection Version, user ModifiedByClientUUID, and user ModifiedByUserUUID need to be pointers? Database says "not null".

(Doesn't need to be changed, just fyi) you could have used nil instead of map[string]bool{} for all the empty maps in the test case, since nobody assigns to them.

Updates at 64dc3f43d
Test run: developer-run-tests-remainder: #1792

• Fixed the Collection type.
• Updated the test to use a more complete collection fixture.

LGTM, thanks!

Checking the merge commit previous to push, I realized I forgot to correct the User type, so I've just did that and also added the modified_by_*_uuid fields to the active user fixture, because the only one that had those fields was the System user, but it lacks of other fields.

Updates at 785bed2f7
Test run: developer-run-tests: #1724