Idea #20300: RailsAPI upgrade from 5.2 to 7.0 - Arvados

Custom queries

All assigned issues
All issues assigned for grooming
My issues for grooming
My issues for grooming (no story pts)
Prioritized open issues

Actions

Copy link

Idea #20300

closed

RailsAPI upgrade from 5.2 to 7.0

Added by Lucas Di Pentima about 1 year ago. Updated 6 months ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Tom Clegg

Category:

API

Target version:

Development 2023-10-25 sprint

Start date:

10/06/2023

Due date:

Story points:

5.0

Description

According to this website, Rails 6.0 will be EOLed in June, so we need to upgrade at least to 6.1

Need to do this to stay on a maintained version of Rails for security fixes.

This is also necessary to support Ubuntu 22.04+, Debian 12+, and RHEL 9+: those distributions have OpenSSL 3.0, which is only supported by Ruby 3.x, which is only supported by Rails 6.

This ticket includes transient dependencies like our google-api-client fork:

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    arvados (~> 2.1.5) was resolved to 2.1.5, which depends on
      arvados-google-api-client (>= 0.7, < 0.8.9) was resolved to 0.8.7.4, which depends on
        activesupport (>= 3.2, < 5.3)

    rails (~> 6.0.0) was resolved to 6.0.1.rc1, which depends on
      activesupport (= 6.0.1.rc1)

Should investigate going up to 7.0 if possible to extend the runway of how long we have to worry about upgrading again.

Should review the Gemfile to see if there are gems that we don't use that don't need to be there.

Subtasks 1 (0 open — 1 closed)

Task #20866: Review 20300-rails7

Resolved

Tom Clegg

10/06/2023

Actions

Related issues

Has duplicate Arvados - Bug #20844: Upgrade API server to Rails 6	Duplicate			Actions
Blocks Arvados - Idea #20846: Support Ubuntu 22.04 LTS	Resolved	Brett Smith	10/30/2023	Actions
Blocked by Arvados - Bug #20862: Deal with our google api client fork in the arvados ruby sdk	Resolved	Tom Clegg	08/18/2023	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Peter Amstutz about 1 year ago

Release deleted (62)
Story points set to 5.0
Description updated (diff)

Actions

Copy link

Updated by Peter Amstutz about 1 year ago

Target version changed from Future to To be scheduled

Actions

Copy link

Updated by Brett Smith 9 months ago

Has duplicate Bug #20844: Upgrade API server to Rails 6 added

Actions

Copy link

Updated by Brett Smith 9 months ago

Description updated (diff)

Actions

Copy link

Updated by Brett Smith 9 months ago

Blocks Idea #20846: Support Ubuntu 22.04 LTS added

Actions

Copy link

Updated by Peter Amstutz 8 months ago

Target version changed from To be scheduled to Development 2023-08-30

Actions

Copy link

Updated by Peter Amstutz 8 months ago

Assigned To set to Tom Clegg

Actions

Copy link

Updated by Tom Clegg 8 months ago

Target version changed from Development 2023-08-30 to Development 2023-09-13 sprint

Actions

Copy link

Updated by Tom Clegg 8 months ago

Blocked by Bug #20862: Deal with our google api client fork in the arvados ruby sdk added

Actions

Copy link

#10

Updated by Tom Clegg 7 months ago

Status changed from New to In Progress

Actions

Copy link

#11

Updated by Peter Amstutz 7 months ago

Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint

Actions

Copy link

#12

Updated by Tom Clegg 7 months ago

Side quest

When deps.go installs nodejs v12.22.12, it comes with npm 6.14.16. When we run npm (run-tests.sh → install apps/workbench), it says

   ╭────────────────────────────────────────────────────────────────╮
   │                                                                │
   │      New major version of npm available! 6.14.16 → 10.0.0      │
   │   Changelog: https://github.com/npm/cli/releases/tag/v10.0.0   │
   │               Run npm install -g npm to update!                │
   │                                                                │
   ╰────────────────────────────────────────────────────────────────╯

https://nodejs.org/en/download/current currently offers

Latest LTS Version: 18.17.1 (includes npm 9.6.7)
Latest Current Version: 20.6.1 (includes npm 9.8.1)

Actions

Copy link

#13

Updated by Lucas Di Pentima 7 months ago

Is that really necessary? Since we're deprecating Workbench1 soon, I mean.

Actions

Copy link

#14

Updated by Tom Clegg 7 months ago

Indeed. Updating workbench1 to rails 6 is officially off the table.

Actions

Copy link

#15

Updated by Tom Clegg 7 months ago

Subject changed from RailsAPI upgrade from 5.2.x to 6.1.x to RailsAPI upgrade from 5.2 to 7.0

Actions

Copy link

#16

Updated by Peter Amstutz 7 months ago

Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint

Actions

Copy link

#17

Updated by Tom Clegg 7 months ago

20300-rails7 @ 80360e3149727e7c3249468782ce605ff3d42a5e -- developer-run-tests: #3851

retry wb1 developer-run-tests-apps-workbench-integration: #4167

retry wb1 developer-run-tests-apps-workbench-integration: #4168

Actions

Copy link

#18

Updated by Lucas Di Pentima 7 months ago

Just a couple of questions, otherwise LGTM:

At 3b40453, there're upgrade changes made to Workbench1, given that wb1 tests passed I guess it was something pending from a previous migration? Just mentioning in case it could cause issues.
Should the line at services/api/config/application.rb:68 be deleted as 6d918ec applies Rails 7 config defaults?

Actions

Copy link

#19

Updated by Peter Amstutz 7 months ago

Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint

Actions

Copy link

#20

Updated by Tom Clegg 6 months ago

20300-rails7 @ 17d60c7ce9d7a358ab59c43d5c8d3afe506e5dad -- developer-run-tests: #3866

20300-rails7 @ 17d60c7ce9d7a358ab59c43d5c8d3afe506e5dad -- developer-run-tests: #3869

At 3b40453, there're upgrade changes made to Workbench1

This just changes all of the update_attributes() to update(). update_attributes() became an alias for update() in Rails 4. Deprecation warnings only show up in Rails 6, so this isn't strictly necessary, but I think it's safe enough that it's not worth reverting.

Should the line at services/api/config/application.rb:68 be deleted as 6d918ec applies Rails 7 config defaults?

Yes, fixed, thanks.

I also added a86a6544f54720c5941a32187235ef5287caee07 to add/restore a small bit of coverage in source:lib/controller/rpc tests. Previously the test suite only tested rpc→railsapi; now it has one rpc→controller test as well.

Actions

Copy link

#21