Bug #3714
closed
- Target version set to Arvados Future Sprints
- Target version changed from Arvados Future Sprints to 2014-09-17 sprint
- Subject changed from small bugs in "report bug on the page" feature to [Workbench] small bugs in "report bug on the page" feature
- Assigned To set to Radhika Chippada
- Status changed from New to In Progress
Reviewing 0313947
- It feels a little unfortunate that the disable code is duplicated, once in the JavaScript's main body and a second time in the input change event. Would it be possible to define a function, call it immediately, and then bind it to the event?
- I'm not sure I understand the purpose of the
trigger
boolean. Would it be simpler to just write the desired actions directly in if
and else
clauses?
- My understanding is that it's JavaScript best practice to use the
===
operator instead of ==
for most comparisons against specific values. This page illustrates the issues with ==
.
- In
report_issue_test.rb
, the button assertion before sending the report is not indented consistently.
Thanks.
c96deb5 looks good to me. Thank you!
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:21c6d252b279c9714419bf65da07e32246572238.
Also available in: Atom
PDF