Bug #4487
closed
[Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions
Added by Bryan Cosca about 10 years ago.
Updated about 10 years ago.
Assigned To:
Radhika Chippada
Files
- Subject changed from Users shouldn't have the option to "Remove selected" when they don't have the proper permissions to [Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions
- Category set to Workbench
- Target version set to Bug Triage
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
- Target version changed from Bug Triage to 2014-12-10 sprint
- Target version changed from 2014-12-10 sprint to Bug Triage
Reviewing 95fd4dd
- In the view, you can just call
@object.editable?
to check if the user has write permission. That covers all the corner cases and will save you some typing.
- In the new test, the name has a typo "avaialble."
- In the test, please go directly to the project page:
visit page_with_token("active", "/projects/#{my_project['uuid']"})
. In general, being more conscientious about what pages we visit in integration tests will help keep test runtimes proportional what we're testing.
- The two
assert_no_selector
lines are redundant. Just checking li
is fine; it will find li.disabled
if that exists. Given this, it might make sense to have all the tests look for li
.
Thanks.
- Target version changed from Bug Triage to 2014-12-10 sprint
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:46aee7d3bec5676e054bddc38633b2775f3a0fd6.
Also available in: Atom
PDF